You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
soundManager supports putting sounds into named "catagories". But when a SoundGenerator is added, specifying a catagory is optional, via option catagoryName. For example:
Because categoryName is optional, this can lead to oversights like phetsims/vegas#98.
Should categoryName be required? Should it default to something that is not null, so that all sounds get put in some "default" category? Is there a reason why every SoundGenerator should NOT be in a category?
The text was updated successfully, but these errors were encountered:
Here's the current state of addSoundGenerator calls. There are zero uses of categoryName in sims, and common code is using it inconsistently. This seems like a good argument for making categoryName required, and standardizing on some categories other that 'ui-sounds'.
We discussed this in today's design team meeting and decided to add the GameAudioPlayer sounds into a category, and have sounds for which no category is specified go into a default category. I will do that work.
soundManager
supports putting sounds into named "catagories". But when a SoundGenerator is added, specifying a catagory is optional, via optioncatagoryName
. For example:soundManager.addSoundGenerator( goBackSoundClip, { categoryName: 'user-interface' } );
Because
categoryName
is optional, this can lead to oversights like phetsims/vegas#98.Should
categoryName
be required? Should it default to something that is notnull
, so that all sounds get put in some "default" category? Is there a reason why every SoundGenerator should NOT be in a category?The text was updated successfully, but these errors were encountered: