You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The process of addressing #151 and #152 have made the sound files a bit bigger. The code for each sound file comes from modulify, but perhaps this can be simplified and instead of creating a 46 line file everything time (which is what it does as of this writing), I could consolidate the code into a separate file that is just referenced by modulify. While this wouldn't likely be a huge gain in terms of reducing the file size, it would help to some degree.
The text was updated successfully, but these errors were encountered:
+1 for addressing this. The current code comes from modulify because that's what it's been implemented to generate. Regardless of whether (or maybe even especially when) it's generated code, it's always preferrable to factor out duplicated code.
The process of addressing #151 and #152 have made the sound files a bit bigger. The code for each sound file comes from
modulify
, but perhaps this can be simplified and instead of creating a 46 line file everything time (which is what it does as of this writing), I could consolidate the code into a separate file that is just referenced bymodulify
. While this wouldn't likely be a huge gain in terms of reducing the file size, it would help to some degree.The text was updated successfully, but these errors were encountered: