Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underlying wav files missing in assets/ #121

Open
zepumph opened this issue Sep 9, 2020 · 1 comment
Open

Underlying wav files missing in assets/ #121

zepumph opened this issue Sep 9, 2020 · 1 comment

Comments

@zepumph
Copy link
Member

zepumph commented Sep 9, 2020

Over in phetsims/scenery-phet#612 (comment) it was outlined that there are multiple places where wav sounds may not be in assets/ dirs for every production sound. I'm wondering if that could be automatically checked on build?

We have grunt reportMedia which looks at license.json files. Is it possible to make an assumption there that any .mp3 or other sound file extensions that there is an accompanying wav file in assets/.

I want to note that maybe this should be a warning instead of an error, since often we don't get wav files until the sound design implementation is really solid.

@jbphet what do you think?
@zepumph zepumph mentioned this issue Sep 9, 2020
Closed
@jbphet
Copy link
Contributor

jbphet commented Sep 10, 2020

Sure, seems like a good idea.

@jbphet jbphet assigned zepumph and unassigned jbphet Sep 10, 2020
@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @zepumph