Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should this repo be type checked? #2

Open
zepumph opened this issue Oct 16, 2024 · 1 comment
Open

How should this repo be type checked? #2

zepumph opened this issue Oct 16, 2024 · 1 comment

Comments

@zepumph
Copy link
Member

zepumph commented Oct 16, 2024

From phetsims/chipper#1487 (comment), there are 10 errors when I run grunt check in phet-lib. I'm unsure what is expected, but likely we need to change some configuration.

@zepumph
Copy link
Member Author

zepumph commented Oct 21, 2024

@jonathanolson @samreid and I looked at this today.

  • tsc -b and tsc doesn't work in phet-vite-demo right now.
  • We do NOT want to put this repo in the grunt check --all.
  • Once we pursue "phase two" with this, where phet-lib exports js + typescript typesc, tsc will likely pass here, and should be added to check --all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant