Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to puppeteer/playwright #393

Open
zepumph opened this issue Oct 30, 2024 · 4 comments
Open

Upgrade to puppeteer/playwright #393

zepumph opened this issue Oct 30, 2024 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Oct 30, 2024

This has been on my list for some time, but I believe this is causing some trouble over in phetsims/aqua#219. On sparky I get some errors like:


90|ct-node-puppeteer-client   | 2024-10-30T16:22:45: error: FAILED TO RUN TEST, Tried to run 3 times, never completed, failure: Error: TimeoutError: Timed out after 30000 ms while trying to connect to the browser! Only Chrome at revision r1056772 is guaranteed to work.
90|ct-node-puppeteer-client   | browserPageLoad caught unexpected error: TimeoutError: Timed out after 30000 ms while trying to connect to the browser! Only Chrome at revision r1056772 is guaranteed to work.

I went through all release notes, and no breaking changes will effect us (that I saw) From https://github.com/puppeteer/puppeteer/releases?page=32 to page 1.

Local testing is going well.

I'm also interested in looking into #372 while here, so that we are all using the same version of puppeteer as needed.

@zepumph
Copy link
Member Author

zepumph commented Oct 30, 2024

grunt generate-phet-io-api works for one repo, but not for --stable.

OOOPS, because I had --transpile=false set.

@zepumph zepumph self-assigned this Oct 30, 2024
@zepumph
Copy link
Member Author

zepumph commented Oct 30, 2024

~23.6.1

@zepumph
Copy link
Member Author

zepumph commented Nov 1, 2024

Some more errors I'm seeing using tsx to launch puppeteer 19:

ct-chrom | 2024-10-31T17:59:03: (node:10112) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 101 SIGINT listeners added to [process]. MaxListeners is 100. Use emitter.setMaxListeners() to increase limit
2|ct-chrom | 2024-10-31T17:59:03: (node:10112) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 101 SIGTERM listeners added to [process]. MaxListeners is 100. Use emitter.setMaxListeners() to increase limit
2|ct-chrom | 2024-10-31T17:59:08: (node:10112) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 101 exit listeners added to [process]. MaxListeners is 100. Use emitter.setMaxListeners() to increase limit
2|ct-chrom | 2024-10-31T17:59:08: (node:10112) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 101 SIGHUP listeners added to [process]. MaxListeners is 100. Use emitter.setMaxListeners() to increase limit



/data/share/phet/continuous-testing/ct-main/ct-snapshots/1730416779720/chipper/node_modules/puppeteer-core/lib/cjs/puppeteer/node/BrowserRunner.js:299
            reject(new Error([
                   ^

Error: Failed to launch the browser process!
[1031/172614.643687:WARNING:discardable_shared_memory_manager.cc(197)] Less than 64MB of free space in temporary directory for shared memory files: 0
[1031/172614.650995:ERROR:file_path_watcher_inotify.cc(333)] inotify_init() failed: Too many open files (24)

@zepumph
Copy link
Member Author

zepumph commented Nov 1, 2024

All the above issues were about a memory leaked solved over in phetsims/aqua#219 (comment).

From here. @samreid and I were wondering if we should instead focus on bringing playwright up to a more modern version instead of puppeteer. It may be time better spent, but it isn't clear right now. I'll investigate.

@zepumph zepumph changed the title Upgrade to puppeteer 23 Upgrade to puppeteer/playwright Nov 1, 2024
@zepumph zepumph removed their assignment Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant