-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to puppeteer/playwright #393
Comments
OOOPS, because I had |
~23.6.1 |
Some more errors I'm seeing using tsx to launch puppeteer 19:
|
All the above issues were about a memory leaked solved over in phetsims/aqua#219 (comment). From here. @samreid and I were wondering if we should instead focus on bringing playwright up to a more modern version instead of puppeteer. It may be time better spent, but it isn't clear right now. I'll investigate. |
This has been on my list for some time, but I believe this is causing some trouble over in phetsims/aqua#219. On sparky I get some errors like:
I went through all release notes, and no breaking changes will effect us (that I saw) From https://github.com/puppeteer/puppeteer/releases?page=32 to page 1.
Local testing is going well.
I'm also interested in looking into #372 while here, so that we are all using the same version of puppeteer as needed.
The text was updated successfully, but these errors were encountered: