Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opportunities for more use of validation options #29

Open
pixelzoom opened this issue Feb 10, 2020 · 0 comments
Open

opportunities for more use of validation options #29

pixelzoom opened this issue Feb 10, 2020 · 0 comments

Comments

@pixelzoom
Copy link
Contributor

Related to #2 (code review);

  • Are Validator validation options (valueType, validValues, etc...) utilized? These are supported in a number of core types like Emitter and Property. Is their presence or lack thereof properly documented?

There's good use of range for NumberProperty.

There is no use of valueType or isValidValue, and it looks like there are opportunities for use, specifically for Vector2Property and Property instances.

This issue code be deferred until PhET-iO instrumentation, when it will become more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant