You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Are Validator validation options (valueType, validValues, etc...) utilized? These are supported in a number of core types like Emitter and Property. Is their presence or lack thereof properly documented?
There's good use of range for NumberProperty.
There is no use of valueType or isValidValue, and it looks like there are opportunities for use, specifically for Vector2Property and Property instances.
This issue code be deferred until PhET-iO instrumentation, when it will become more important.
The text was updated successfully, but these errors were encountered:
Related to #2 (code review);
There's good use of
range
for NumberProperty.There is no use of
valueType
orisValidValue
, and it looks like there are opportunities for use, specifically forVector2Property
andProperty
instances.This issue code be deferred until PhET-iO instrumentation, when it will become more important.
The text was updated successfully, but these errors were encountered: