Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemical formulas read out as words #215

Closed
KatieWoe opened this issue Jan 7, 2020 · 10 comments
Closed

Chemical formulas read out as words #215

KatieWoe opened this issue Jan 7, 2020 · 10 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 7, 2020

For phetsims/qa#464. Similar in nature to phetsims/molecules-and-light#255.
Found when testing iPad VO. When vowels were in the chemical formulas and could make pronounceable sounds, they would be read as words, rather than as individual letters. The most problematic is NO (as in nitrogen and oxygen) being read as "number."

@jessegreenberg
Copy link
Contributor

Like phetsims/molecules-and-light#255 I don't think there is anything we can do about this other than certain workarounds.
From https://www.levelaccess.com/zip-z-p-z-p-forcing-correct-pronunciation-screen-readers/

Current solutions are either not elegant or not well-supported. Non-elegant solutions are generally not encouraged, however, below are some suggestions (when necessary) for forcing a pronunciation on a screen reader.

@terracoda is this something that PhET needs to address or can this be closed?

@terracoda
Copy link
Contributor

I reviewed the A11y View and all the formulas look correct (proper capitalization and sub-scripted numbers). I also think they all sound prett good. Because they are in the PDOM, screen reader users can use letter-by-letter reading to to analyze the content if they need to.

When I looked at the code, I see we are not using an abbr tag. And I see teh subscripted "4" in the screenshot below is outside the quotations. Is that a problem? NUmbers, I suppose, don't need translation, so I think that's why, but just want to check.

Screen Shot 2020-01-09 at 4 49 07 PM
the A11y View, but I think everything is coded properly.

So, to sum up, we can investigate using an abbr tag, but I am pretty sure others have tested this and it doesn't help with pronunciation. It might help in other ways in terms of communication it is an abbreviation or be more future compliant, so we should investigate. This should not bock publication. I will open an issue in the A11y Research repo.

@terracoda
Copy link
Contributor

I think when we investigate more with MathML, we can look into this deeper - there is a ChemML, but I have no idea if it is any good or supported by screen reader software.

@jessegreenberg, after publication we can test the abbr tag, we have chemical names in Molecules and Light, so we can experiment there and leave this as a possible maintenance release if we discover a nice solution for MAL.

Molarity sound pretty to me.

@jessegreenberg, if there are no concerns about the number 4 being outside the quotation marks, can you please close this issue?

@terracoda
Copy link
Contributor

Just adding a couple more links I saw, which I might look at more later.

@terracoda terracoda assigned jessegreenberg and unassigned terracoda Jan 9, 2020
@terracoda
Copy link
Contributor

@jessegreenberg, also, I think @twant may have tried the abbr tag, but I can't be sure.

@terracoda
Copy link
Contributor

Re-posting my comment for wrapping up:

@jessegreenberg, if there are no concerns about the number 4 being outside the quotation marks, can you please close this issue?

@jessegreenberg
Copy link
Contributor

Thanks for inspecting @terracoda. I am not concerned about the quotations. I don't think it is about translation but more about how the dev tools display text. If the element is copied out of dev tools the quotes go away.

<li data-trail-id="356-357-440-446-441-447-471-473-477" id="356-357-440-446-441-447-471-473-477" data-focusable="false" class="a11y-sibling" tabindex="-1">chemical formula of potassium chromate is K<sub tabindex="-1">2</sub>CrO<sub tabindex="-1">4</sub></li>

Going to make a note in the QA screen reader document that we don't expect the device to read chemical formulas correctly.

@jessegreenberg
Copy link
Contributor

OK made note, closing.

@terracoda
Copy link
Contributor

@jessegreenberg, thanks for letting me know that the quotes are from devtools!

@jessegreenberg
Copy link
Contributor

Well, its my best guess anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants