Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self review each class. #136

Closed
4 of 46 tasks
veillette opened this issue Jul 28, 2021 · 2 comments
Closed
4 of 46 tasks

Self review each class. #136

veillette opened this issue Jul 28, 2021 · 2 comments
Assignees

Comments

@veillette
Copy link
Contributor

veillette commented Jul 28, 2021

COMMON
model

  • FocalPoint.js

  • GeometricOpticsModel.js

  • LightRay.js

  • LightRayMode.js

  • LightRays.js

  • Optic.js

  • Ray.js

  • Representation.js

  • Ruler.js

  • SourceObject.js

  • Target.js
    view

  • CurveControl.js

  • FocalPointNode.js

  • GeometricOpticsControlPanel.js

  • GeometricOpticsRulerNode.js

  • GeometricOpticsRulersLayer.js

  • GeometricOpticsScreenView.js

  • LabelNode.js

  • LabelsNode.js

  • LightRaysNode.js

  • OpticalAxisLine.js

  • OpticNode.js

  • RepresentationComboBox.js

  • ShowHideToggleButton.js

  • SourceObjectNode.js

  • TargetNode.js

  • ToolboxPanel.js

  • TrackingDiskNode.js

  • VisibleProperties.js

  • geometricOpticsColorProfile.js

  • GeometricOpticsConstants.js

  • GeometricOpticsQueryParameters.js

LENS
model

  • Guide.js

  • LensModel.js

  • ProjectorScreen.js

  • Spotlight.js
    view

  • GuideNode.js

  • LensScreenView.js

  • ProjectorScreenNode.js

  • LensScreen.js

MIRROR
model

  • MirrorModel.js
    view

  • MirrorScreenView.js

  • MirrorScreen.js

  • geometric-optics-main.js

  • geometricOptics.js

  • geometricOpticsStrings.js

@veillette veillette self-assigned this Jul 28, 2021
@veillette
Copy link
Contributor Author

Should review for

  • All classes, methods and properties are documented.

  • Documentation at the top of .js files should provide an overview of purpose, responsibilities, and (where useful) examples of API use. If the file contains a subclass definition, it should indicate what functionality it adds to the superclass.

@veillette
Copy link
Contributor Author

I did not end up using this for the self review. SInce #129 is now closed. We can close this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant