From f8a264d39ff25e66dec18c072a288d48edb6aa04 Mon Sep 17 00:00:00 2001 From: Michael Kauzmann Date: Tue, 4 Apr 2023 13:13:09 -0600 Subject: [PATCH] manually dispose KeyboardHelpSectionRows, https://github.com/phetsims/scenery-phet/issues/769 --- js/common/view/GOKeyboardHelpContent.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/js/common/view/GOKeyboardHelpContent.ts b/js/common/view/GOKeyboardHelpContent.ts index 8cbe2421..516730fb 100644 --- a/js/common/view/GOKeyboardHelpContent.ts +++ b/js/common/view/GOKeyboardHelpContent.ts @@ -101,8 +101,7 @@ class MoveDraggableItemsSection extends KeyboardHelpSection { this.disposeMoveDraggableItemsSection = () => { icons.forEach( icon => icon.dispose() ); - //TODO https://github.com/phetsims/scenery-phet/issues/769 uncomment when KeyboardHelpSection no longer disposes of content - //rows.forEach( row => row.dispose() ); + rows.forEach( row => row.dispose() ); }; } @@ -148,8 +147,7 @@ class RulerAndMarkerControlsSection extends KeyboardHelpSection { this.disposeRulerAndMarkerControlsSection = () => { keyNodes.forEach( keyNode => keyNode.dispose() ); - //TODO https://github.com/phetsims/scenery-phet/issues/769 uncomment when KeyboardHelpSection no longer disposes of content - //rows.forEach( row => row.dispose() ); + rows.forEach( row => row.dispose() ); }; }