Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launched sim freezes with safari #278

Closed
Nancy-Salpepi opened this issue Mar 30, 2022 · 17 comments
Closed

Launched sim freezes with safari #278

Nancy-Salpepi opened this issue Mar 30, 2022 · 17 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3

Browser
Safari

Problem description
For phetsims/qa#791
When I try to interact with the launched sim in safari, it freezes. After a delay the 'releasing book' sound is heard. When I return to the Studio wrapper it also looks odd and takes a few seconds to return to normal.

  • this did not happen with mac + Chrome
  • this also occurred in Master ( I tried other sims in Master and while Studio took a while to open, no freezing occurred)
  • Nothing came up in the console
  • @KatieWoe was also able to reproduce this problem so it is not device specific.

Steps to reproduce

  1. Launch the sim from studio
  2. Attempt to move the book.
  3. Go back to the studio wrapper

Visuals

phetiOsafari.mp4
@KatieWoe
Copy link
Contributor

I reproduced this on iPad by launching the example sim

@Nancy-Salpepi
Copy link
Author

In studio with safari --the preview HTML worked properly.

@KatieWoe
Copy link
Contributor

KatieWoe commented Apr 4, 2022

This also happened when trying to record on iPad with Metacog recording. @zepumph note that Metacog wasn't tested due to this.

@KatieWoe
Copy link
Contributor

KatieWoe commented Apr 5, 2022

Very interesting find on iPad. I made a file with studio on Win 11 Chrome, hosted it on a server, and played that file on iPad safari without this crash occurring.

@zepumph
Copy link
Member

zepumph commented Jul 15, 2022

I believe that the sim has frozen because of an error in the launched sim. It would be best if you could run this test:

  1. Go to studio
  2. Press the launch button in the desired state to reproduce
  3. In the launched tab, open the dev tools
  4. Then interact with the sim to make it freeze

Is there a console error in the launched sim?

@zepumph zepumph assigned KatieWoe and unassigned zepumph Jul 15, 2022
@KatieWoe
Copy link
Contributor

No, nothing appears in the console

@KatieWoe KatieWoe assigned zepumph and unassigned KatieWoe Jul 15, 2022
@zepumph
Copy link
Member

zepumph commented Jul 15, 2022

A saw in the video that the launch sim tab had crashed when you went back to the tab after looking in the console in Studio. Can you please try to reproduce this on master on phettest to see if it is still a bug?

@KatieWoe
Copy link
Contributor

It's still happening in master. I didn't see a console error there either.

@zepumph
Copy link
Member

zepumph commented Jul 26, 2022

Sam has a mac, and I solicited his help here. Thank you!

@samreid
Copy link
Member

samreid commented Jul 26, 2022

I tested Safari Version 15.2 (17612.3.6.1.6) on MacOS Monterey 12.1, and launched https://phet-dev.colorado.edu/html/friction/1.6.0-dev.24/phet-io/wrappers/studio/ then pressed "preview sim" then moved the book and went back to studio. Everything continued to behave as expected.

@zepumph
Copy link
Member

zepumph commented Jul 26, 2022

@Nancy-Salpepi can we please schedule some time to pair on this. I think next steps would be to try to reproduce on the original machine. Thanks for testing @samreid!

@Nancy-Salpepi
Copy link
Author

Sure @zepumph! I am around tomorrow. Let me know what works for you.

@samreid
Copy link
Member

samreid commented Jul 27, 2022

I was not able to reproduce this problem or phetsims/gravity-and-orbits#421 on Safari Version 15.2 (17612.3.6.1.6) on MacOS 12.1.

I was able to reproduce this on my iPad 15.5 and iPhone 15.4.1. After updating both to 15.6, I am not able to see the problem any more on either of those devices after many tests. I also updated my macOS to get Safari 15.6 and still cannot see the problem there. So the hypothesis is that Safari introduced a bug between 15.3 -> 15.5 and fixed it in 15.6. @Nancy-Salpepi do you have Safari 15.6 devices you can test, or can you update your 15.5 safaris for a test?

@Nancy-Salpepi
Copy link
Author

@samreid I will update everything now and see if I can reproduce.

@samreid
Copy link
Member

samreid commented Jul 27, 2022

@marlitas tested on Safari 15.5 and saw the problem in 2/2 tests (at about 4 seconds each).

@Nancy-Salpepi
Copy link
Author

@samreid After updating to Safari 15.6 I wasn't able to produce the problem (0/4), even with clearing history each time.

@zepumph
Copy link
Member

zepumph commented Jul 27, 2022

Awesome! Thanks for the hard work everyone.

@zepumph zepumph closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants