-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launched sim freezes with safari #278
Comments
I reproduced this on iPad by launching the example sim |
In studio with safari --the preview HTML worked properly. |
This also happened when trying to record on iPad with Metacog recording. @zepumph note that Metacog wasn't tested due to this. |
Very interesting find on iPad. I made a file with studio on Win 11 Chrome, hosted it on a server, and played that file on iPad safari without this crash occurring. |
I believe that the sim has frozen because of an error in the launched sim. It would be best if you could run this test:
Is there a console error in the launched sim? |
No, nothing appears in the console |
A saw in the video that the launch sim tab had crashed when you went back to the tab after looking in the console in Studio. Can you please try to reproduce this on master on phettest to see if it is still a bug? |
It's still happening in master. I didn't see a console error there either. |
Sam has a mac, and I solicited his help here. Thank you! |
I tested Safari Version 15.2 (17612.3.6.1.6) on MacOS Monterey 12.1, and launched https://phet-dev.colorado.edu/html/friction/1.6.0-dev.24/phet-io/wrappers/studio/ then pressed "preview sim" then moved the book and went back to studio. Everything continued to behave as expected. |
@Nancy-Salpepi can we please schedule some time to pair on this. I think next steps would be to try to reproduce on the original machine. Thanks for testing @samreid! |
Sure @zepumph! I am around tomorrow. Let me know what works for you. |
I was not able to reproduce this problem or phetsims/gravity-and-orbits#421 on Safari Version 15.2 (17612.3.6.1.6) on MacOS 12.1. I was able to reproduce this on my iPad 15.5 and iPhone 15.4.1. After updating both to 15.6, I am not able to see the problem any more on either of those devices after many tests. I also updated my macOS to get Safari 15.6 and still cannot see the problem there. So the hypothesis is that Safari introduced a bug between 15.3 -> 15.5 and fixed it in 15.6. @Nancy-Salpepi do you have Safari 15.6 devices you can test, or can you update your 15.5 safaris for a test? |
@samreid I will update everything now and see if I can reproduce. |
@marlitas tested on Safari 15.5 and saw the problem in 2/2 tests (at about 4 seconds each). |
@samreid After updating to Safari 15.6 I wasn't able to produce the problem (0/4), even with clearing history each time. |
Awesome! Thanks for the hard work everyone. |
Test device
MacBook Air (m1 chip)
Operating System
12.3
Browser
Safari
Problem description
For phetsims/qa#791
When I try to interact with the launched sim in safari, it freezes. After a delay the 'releasing book' sound is heard. When I return to the Studio wrapper it also looks odd and takes a few seconds to return to normal.
Steps to reproduce
Visuals
phetiOsafari.mp4
The text was updated successfully, but these errors were encountered: