Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility annotations should be checked and corrected as needed #9

Open
jbphet opened this issue Dec 2, 2020 · 0 comments
Open

Visibility annotations should be checked and corrected as needed #9

jbphet opened this issue Dec 2, 2020 · 0 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Dec 2, 2020

In #8 the code for this sim was modified to be in ES6 style. When this was done, the sim started failing lint due to a lack of visibility annotations. It's been a long time since I did any work on this sim, so it's not fresh in my mind, and it may never see the light of day again, so it didn't seem worth the time and effort it would take to make sure that all of the visibility annotations are correct. So, I just marked anything I wasn't sure of as @public and added a TODO to the corresponding file. This should be fixed up if and when this sim is revived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant