Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Data: Textarea" wrapper is laggy #313

Closed
pixelzoom opened this issue Mar 23, 2023 · 3 comments
Closed

"Data: Textarea" wrapper is laggy #313

pixelzoom opened this issue Mar 23, 2023 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Mar 23, 2023

In phetsims/qa#921 (comment), @KatieWoe asked:

The sim seems to be quite laggy when using the Data: Textarea wrapper. Is this a concern/worth an issue?

In phetsims/qa#921 (comment), @veillette replied:

You are probably trying to change the curve points. There is a lot of meta data associated with a curve since all points have some metadata associated with them. You can create an issue though.

Indeed, the state for this sim is huge.

@zepumph @samreid What do you recommend for this? Is the "Data: Textarea" wrapper supposed to be responsive?

@samreid
Copy link
Member

samreid commented Mar 24, 2023

I'm seeing 2-3 frames per second while dragging curves in the text area wrapper on Mac/Chrome for the dev version linked above. That seems fine to me. Even if it was 0.2 frames per second, that seems OK. It is not expected that outputting a large amount of streaming data to the DOM would be performant--clients would not want to leverage the data stream in that way.

@samreid samreid assigned KatieWoe and unassigned samreid and zepumph Mar 24, 2023
@pixelzoom
Copy link
Contributor Author

@samreid said:

... That seems fine to me. ...

Since the PhET-iO team is recommending no change, I'll close this issue as "won't fix".

@zepumph
Copy link
Member

zepumph commented Mar 24, 2023

Noting a theme that our current exploratory PhET-iO feature tools (the wrapper suite) often causes explainable problems that may result in a client thinking that PhET-iO is buggy rather than just piping >5MB to a text area every frame. We should definitely design the client experience on feature set exemplars soon! (like with https://github.com/phetsims/phet-io-wrappers/issues/129)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants