Fix nested enums in meta #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested enums caused an exception when processed through meta-helpers. Fixed it for now.
Add comments to explain processing.
Current coverage is 36.22%@@ master #49 diff @@
==========================================
Files 117 117
Lines 4874 4881 +7
Methods 0 0
Messages 0 0
Branches 973 979 +6
==========================================
Hits 1768 1768
- Misses 2872 2879 +7
Partials 234 234
|
|
Is this enough for a new release? |
|
I have no rush:) Personally I have no agenda for jcodemodel and plan no further changes in a mean time, so you can freely proceed with the release as you feel right. |
|
I got quite quiet in the last time so I think people are happy with the "as is" situation (or they changed to some library???). Anyway I will release it to indicate progress :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.