Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog Browser: createRepositoryURLtoNameMappings needs to be fixed due to missing #asArray method #4716

Closed
astares opened this issue Sep 24, 2019 · 3 comments

Comments

@astares
Copy link
Member

astares commented Sep 24, 2019

In Pharo 8 the #asArray method is missing. This brings a problem when the Catalog Browser is opened / refreshed because integer DNU #2388

So instead of writing:

v asArray

we need to write

(Array with: v)

The full fix is to change the #createRepositoryURLtoNameMappings method like this:

createRepositoryURLtoNameMappings
	"Return a mapping between repositories URLs and their user names"

	<script: 'self createRepositoryURLtoNameMappings inspect'>
	|repos|
	repos := Dictionary new.	
	3 to: SystemVersion current major do: [:v | 
		repos 	
			at: ('http://smalltalkhub.com/mc/Pharo/MetaRepoForPharo{1}0/main' format: (Array with: v))
			put: ('Pharo{1}.0' format: (Array with: v))].
	repos at: 'http://www.squeaksource.com/MetacelloRepository' put: 'Unsorted'.		
	^repos
 

No time now for doing a proper PR from this laptop here.

@astares
Copy link
Member Author

astares commented Sep 24, 2019

#(v)  

would be even easier

@Ducasse
Copy link
Member

Ducasse commented Sep 24, 2019

You can also use {v} because #(v) will not work.

@MarcusDenker
Copy link
Member

this was done.method uses {v} everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants