Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github pages not deploying #226

Closed
barnett11 opened this issue Dec 11, 2024 · 5 comments
Closed

Github pages not deploying #226

barnett11 opened this issue Dec 11, 2024 · 5 comments

Comments

@barnett11
Copy link
Collaborator

Background Information

Pages deployment is constantly failing and not updating our documentation. It works locally using pkgdown, @cicdguy would you have any recommendations please?

Definition of Done

No response

@cicdguy
Copy link
Collaborator

cicdguy commented Dec 12, 2024

Hi @barnett11

I'm not seeing the failures. Can you post the links to the failed workflows here?

@barnett11
Copy link
Collaborator Author

Hi @barnett11

I'm not seeing the failures. Can you post the links to the failed workflows here?

Apologies - see here thanks @cicdguy - if you look at the Actions it always has a failure and a success, but the failure seems to be the main one being used as documentation is not matching what we're submitting
https://github.com/pharmaverse/datacutr/actions/runs/12272971290/job/34242823923

@cicdguy
Copy link
Collaborator

cicdguy commented Dec 13, 2024

I see. If you expand the Annotations section on that job summary, it tells you why it was canceled.

Screenshot 2024-12-13 at 7 18 38 AM

This means that another deployment was already in progress, and the job request was canceled to prioritize the one that triggered before it.

This means that there are multiple deployments to gh-pages going on. Let's see what those are.

@cicdguy
Copy link
Collaborator

cicdguy commented Dec 13, 2024

Ok I see what's happening.

tl;dr

I'll fix this.

Long explanation

We made some major performance improvements for the multiversion docs (the Versions dropdown in the site navbar that lets you choose between main and devel).

When the docs via pkgdown::build_site() get published to gh-pages, it triggers the GitHub-managed "pages build and deployment" job.

While the first instance of "pages build and deployment" job is triggered, the multiversion docs job triggers and finishes very quickly (due to the performance improvements). Then, it triggers another instance of the "pages build and deployment" job.

Due to the way the concurrency features work for the "pages build and deployment" job, the first job takes precedence and the second one is automatically canceled.

@barnett11
Copy link
Collaborator Author

Many thanks @cicdguy , the Actions were now successful for building the pages. Many thanks for the help as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants