Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update link to the Github repository in the Programming Strategy #134

Closed
sadchla-codes opened this issue Oct 19, 2022 · 3 comments · Fixed by #138
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sadchla-codes
Copy link
Collaborator

Please select a category the issue is focused on?

Developer Guides

Let us know where something needs a refresh or put your idea here!

The GitHub Repository link in the R and package versions for development section of the Programming Strategy is not working.
github_repository_issues

The landing page is an error 404 message.
github_repository_issues_result

Also need to (possibly) update the current R versions for admiral in the following paragraphs
R version

@sadchla-codes sadchla-codes added the documentation Improvements or additions to documentation label Oct 19, 2022
@sadchla-codes sadchla-codes self-assigned this Oct 19, 2022
@sadchla-codes
Copy link
Collaborator Author

sadchla-codes commented Oct 19, 2022

@bms63 @thomas-neitmann @rossfarrugia It appears that the link for the GitHub repository from the "Programming Strategy" is suppose to lead to a R-CMD-check.yml but that doesn't exist there
programming_strategy

I'll still point the link to the /workflow/ folder, but should R-CMD-check.yml have included in that folder?
workflow_page

For my clarification (sorry if I should have read this somewhere), the link should be the main base workflow folder, not devel, correct?

Additionally, since the R version for the workflow in the common.yml is still 3.6,

  • I think it might be best to change the version in the 'Programming Strategy' once the version is changed in the common.yml, so I will change the title of the issue, thoughts?
  • Can I manually change it here (i think based on past discussion, we agreed it might have been okay, but I can't recall.)?

workflow_version

@sadchla-codes sadchla-codes changed the title Documentation: Update link to the Github repository, and Current R Version being tested in the Programming Strategy Documentation: Update link to the Github repository in the Programming Strategy Oct 19, 2022
@sadchla-codes sadchla-codes linked a pull request Oct 20, 2022 that will close this issue
14 tasks
@rossfarrugia
Copy link
Collaborator

@sadchla-codes we moved all our central CI/CD workflows to admiralci so the link should be https://github.com/pharmaverse/admiralci/blob/main/.github/workflows/r-cmd-check.yml. Then the common.yml file in each repo let's teams select which workflows they need from the central list.

@bms63 could answer the other question but i think this should also be changed to 4.0 now.

@bms63
Copy link
Collaborator

bms63 commented Oct 20, 2022

Upgrading to 4.0 now.

I think we should make the language agnostic to the version numbers, so we don't have to continuously update this part of the strategy. We only use the three latest R versions and the closest date of snapshots of R packages available when that R version came out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging a pull request may close this issue.

3 participants