Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test coverage for set_admiral_options() #2577

Closed
1 task
manciniedoardo opened this issue Nov 27, 2024 · 2 comments
Closed
1 task

Enhance test coverage for set_admiral_options() #2577

manciniedoardo opened this issue Nov 27, 2024 · 2 comments
Labels

Comments

@manciniedoardo
Copy link
Collaborator

manciniedoardo commented Nov 27, 2024

Background Information

It would be great to get {admiral}'s test coverage to 100%. However, this should not come at the expense of development time/effort from {admiral} core developers. As such, I have made a set of issues tagged "Unit Tests" (such as this one for set_admiral_options()) where users who wish to dip their feet into the {admiral}` ecosystem can:

  • Learn a bit about unit testing for R packages
  • Make a meaningful contribution to {admiral}

by adding or modifying unit tests to account for lines not previously covered.

Important note: Given the above, this issue is for newcomers to {admiral} or users who wish to contribute to the package, and should not be taken on by core {admiral} developers.

Definition of Done

  • Unit test(s) added/modified to test the lines in red in set_admiral_options():
    image
@bms63
Copy link
Collaborator

bms63 commented Nov 27, 2024

I wonder if we really need tests for the roxygen stuff? Maybe that should get moved to pharmaverse4devs? @bundfussr

@manciniedoardo manciniedoardo changed the title Enhance test coverage for roxygen_param_by_vars(), use_ad_template(), set_admiral_options() Enhance test coverage for roxygen_param_by_vars(), use_ad_template() Dec 12, 2024
@manciniedoardo manciniedoardo changed the title Enhance test coverage for roxygen_param_by_vars(), use_ad_template() Enhance test coverage for set_admiral_options() Dec 12, 2024
@manciniedoardo
Copy link
Collaborator Author

I updated this issue so it's only about set_admiral_options() and put the other two functions in #2605.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants