Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issue: Follow Deprecate Strategy for function from 0.7, 0.8, 0.9 #1666

Closed
bms63 opened this issue Jan 11, 2023 · 4 comments
Closed
Assignees

Comments

@bms63
Copy link
Collaborator

bms63 commented Jan 11, 2023

Background Information

We missed deprecating functions from our last release. Just putting this as a placeholder so we don't forget!!

Definition of Done

Functions from 0.7 and 0.8 that were deprecated are removed.

Functions deprecated with warning in 0.9 are set to error.

https://pharmaverse.github.io/admiraldev/devel/articles/programming_strategy.html#deprecation

@bms63
Copy link
Collaborator Author

bms63 commented Jan 11, 2023

Starting to think that this should be an auto-generated issue when a release is done so we keep line of sight.

@bundfussr
Copy link
Collaborator

@bms63 , it seems we miss this frequently. I would suggest implementing pharmaverse/admiraldev#36.

Maybe @zdz2101 is interested in implementing pharmaverse/admiraldev#36.

@zdz2101
Copy link
Collaborator

zdz2101 commented Jan 12, 2023

I'll have a look!

@zdz2101 zdz2101 self-assigned this Jan 12, 2023
@bms63 bms63 assigned sadchla-codes and unassigned zdz2101 Feb 8, 2023
@bms63 bms63 moved this from Priority to In Progress in admiral (sdtm/adam, dev, ci, template, core) Feb 8, 2023
@sadchla-codes
Copy link
Collaborator

Already addressing this in issue #1723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants