Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: derive_param_tte() should not create observations for subjects not in ADSL #1576

Closed
bundfussr opened this issue Nov 10, 2022 · 0 comments · Fixed by #1644
Closed

Feature Request: derive_param_tte() should not create observations for subjects not in ADSL #1576

bundfussr opened this issue Nov 10, 2022 · 0 comments · Fixed by #1644
Labels
documentation Improvements or additions to documentation enhancement New feature or request programming

Comments

@bundfussr
Copy link
Collaborator

Feature Idea

Currently derive_param_tte() creates observations for subjects which have an event or are censored but who are not in ADSL. For those STARTDT is NA, which implies that AVAL is NA as well. So these observations are useless for time-to-event analyses.

derive_param_tte() should be updated such that such observations are not created.

Additionally the documentation should be updated where it mentions the start_imputation_flag argument. This argument does not exist.

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@bundfussr bundfussr added enhancement New feature or request programming labels Nov 10, 2022
@bundfussr bundfussr added the documentation Improvements or additions to documentation label Nov 10, 2022
@rossfarrugia rossfarrugia mentioned this issue Dec 2, 2022
Closed
@bundfussr bundfussr moved this from Priority to In Progress in admiral (sdtm/adam, dev, ci, template, core) Dec 20, 2022
@bundfussr bundfussr linked a pull request Dec 20, 2022 that will close this issue
Closes #1576 1576_update_param_tte: keep only obs for subjects in dataset_adsl #1644
Merged
14 tasks
@bundfussr bundfussr moved this from In Progress to In Review in admiral (sdtm/adam, dev, ci, template, core) Dec 20, 2022
@rossfarrugia rossfarrugia mentioned this issue Mar 7, 2023
Closed
@bms63 bms63 closed this as completed in 51f5b96 Mar 7, 2023
@rossfarrugia rossfarrugia mentioned this issue May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #1576 1576_update_param_tte: keep only obs for subjects in dataset_adsl pharmaverse/admiral
2 participants
@bundfussr @rossfarrugia