Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the scope of release 0.9.0 #1374

Closed
duniek opened this issue Aug 24, 2022 · 12 comments
Closed

Define the scope of release 0.9.0 #1374

duniek opened this issue Aug 24, 2022 · 12 comments
Assignees

Comments

@duniek
Copy link

duniek commented Aug 24, 2022

Background Information

Create a list of features that would be part of the next release in December.
Highlight which would be the highest priority.

Definition of Done

List of desired features/ updates available

Timeline: A new release will occur in early December 2022 (release Q4-2022).
Theme: Developer and Adoption Focus
Synopsis:

A two prong strategy is adopted. As admiral sprawls out, we are in need of updating and enhancing our developer documents and processes. Emphasis will be placed on ensuring that our developer vignettes are up to date with our best practices and that theses are implemented throughout our admiral packages and repos. At the same time, we also need to ensure that admiral is being adopted at our respective parent companies and the boarder community. Emphasis will also be placed on updating and creating additional users guides, documentation, video walkthroughs and continuing with our monthly beginner admiral series.

admiral bugs still receive the highest priority to fix and address. Additional work on new functions, new workflows, etc, with the exception of those identified for this release, should be addressed after we have allocated appropriate resourcing to developer and adoption strategy.

Issues that address this strategy have been tagged with (release Q4-2022).

@thomas-neitmann thomas-neitmann changed the title Define the scope of release 0.0.9 Define the scope of release 0.9.0 Aug 24, 2022
@rossfarrugia
Copy link
Collaborator

@bms63 @thomas-neitmann @millerg23 FYI here's some early ones to add to the list that we'd appreciate consideration to be prioritised for next release from a Roche selfish perspective...

@bms63
Copy link
Collaborator

bms63 commented Aug 26, 2022

@bms63
Copy link
Collaborator

bms63 commented Aug 29, 2022

#1235 Address 2 issues created around library(pkg_name) and pkg_name::function()

@bms63
Copy link
Collaborator

bms63 commented Aug 31, 2022

#1402 and #1396 For documentation harmony/clarification

@rossfarrugia
Copy link
Collaborator

and pharmaverse/admiraldev#72 on similar note

@duniek
Copy link
Author

duniek commented Sep 7, 2022

Note from our meeting:
general theme: development focus
some issues are needed for admiralRoche
issues needed for ADLB
admiral dev code coverage boost up to 80%
admiral.dev
PK - potentially a separate extension package

push on adoption side - event/hackathon across industry
additional videos: admiral intro, how to build additional datasets

@esimms999-gsk
Copy link
Contributor

Have a discussion wrt translating documentation to other languages. If this is something we eventually want done, then attempt to translate one portion of the documentation (ReadMe?) from English to another language and figure out how that and subsequent translations can be managed.

@cicdguy
Copy link
Collaborator

cicdguy commented Sep 7, 2022

Have a discussion wrt translating documentation to other languages. If this is something we eventually want done, then attempt to translate one portion of the documentation (ReadMe?) from English to another language and figure out how that and subsequent translations can be managed.

Does Google Translate help here? One can easily embed translation features into the pkgdown docs.

@rossfarrugia
Copy link
Collaborator

Have a discussion wrt translating documentation to other languages. If this is something we eventually want done, then attempt to translate one portion of the documentation (ReadMe?) from English to another language and figure out how that and subsequent translations can be managed.

Maybe one more for down the line? I'd personally still say we have plenty of common template/function gaps I'd prefer us cover above this like hy's law, questionnaires, what to do with crossover/periods, etc.

@bundfussr
Copy link
Collaborator

I tried to translate the admiral page to German with google translate. Most of the text is readable but I would prefer reading the original version. (Some parts are funny but not helpful, e.g., google tries to translate the argument names on the function documentation pages.)

I agree with @rossfarrugia that there are more important topics. I think the main question is if we have resources to work on them.

@rossfarrugia
Copy link
Collaborator

I think the main question is if we have resources to work on them.

Still working on new resources... trying to bring 2.5 more devs our way over next month or 2 🤞

@thomas-neitmann
Copy link
Contributor

As for resources, there are apparently 5 new hires out of SSF that are keen to contribute to our next gen tools. I'd like to get them involved with writing unit tests for {admiraldev} first. Once they get the hang of our process I'm sure they'd be eager to contribute to issues within {admiral}. I'll keep ypu posted on updates.

@bms63 bms63 moved this from In Progress to Done in admiral (sdtm/adam, dev, ci, template, core) Sep 21, 2022
Repository owner moved this from Done to In Review in admiral (sdtm/adam, dev, ci, template, core) Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants