Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat config & ESLint 9 support #68

Open
phanect opened this issue Dec 30, 2023 · 4 comments
Open

Flat config & ESLint 9 support #68

phanect opened this issue Dec 30, 2023 · 4 comments
Assignees

Comments

@phanect
Copy link
Owner

phanect commented Dec 30, 2023

Priority: High ― Start after #70

@phanect phanect self-assigned this Dec 30, 2023
@phanect phanect changed the title Flat config & TypeScript support Flat config support Jan 3, 2024
@phanect phanect changed the title Flat config support Flat config & ESLint 9 support Apr 21, 2024
@phanect phanect pinned this issue Apr 21, 2024
@FezVrasta
Copy link

FezVrasta commented Oct 25, 2024

What exactly is needed here? I was able to use this plugin with flat config with the following config:

import editorConfigPlugin from "eslint-plugin-editorconfig";

 {
    files: ["**/*"],
    plugins: {
      editorconfig: editorConfigPlugin,
    },
    rules: {
      ...editorConfigPlugin.configs.all.rules,
    },
  },

@phanect
Copy link
Owner Author

phanect commented Oct 26, 2024

Really?
When I tested, this plugin didn't work properly at all with flat config.

IIRC, I have tested when ESLint was v8, so ESLint might be updated so that legacy .eslintrc-based plugin works.
I will test if it works as expected with flat config, and if it works, I will add instructions for flat config into README.

Thanks for the info!

@phanect
Copy link
Owner Author

phanect commented Oct 28, 2024

I quickly tested your config, but unfortunately, it didn't work on my end.
This plugin internally calls the ESLint rules such as indent and linebreak-style, so it should not work with ESLint v9 since those rules are already removed.

@FezVrasta
Copy link

I'm using it only for the empty line at EOF so maybe that's why it worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants