-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cache backends bug #11322 #11323
Conversation
Can you please provide a small test? |
I think it's just a issue related to checking if variable is null.
In this case, if content parameter is 0 or "0", It works as if content is null. apc.zep and memory.zep already use |
In any case, you must show that your PR has solved the issue. Now it is impossible to check without accepting your PR. A little test would have shown - issue is solved or not without accepting the PR to the main codebase |
c05b2df
to
9782821
Compare
@sergeyklay |
Can you please rebase onto |
9782821
to
74efa24
Compare
@sergeyklay I have rebased onto 2.0.x |
74efa24
to
1037e14
Compare
Fine. How about: $cache->save('test-zero-data', 0); // int, not string. as described in issue #11322
// or
$cache->save('test-zero-data', false); can you please also provide these test cases |
@@ -9,8 +9,7 @@ | |||
- Fixed `Phalcon\Translate\Adapter\Gettext::exists` bug[#11310](https://github.com/phalcon/cphalcon/issues/11310) related to the wrong returned value (always true) | |||
- Fixed `Phalcon\Translate\Adapter\Gettext::setLocale` bug[#11311](https://github.com/phalcon/cphalcon/issues/11311) related to the incorrect setting locale | |||
- Added ability to persistent connection in `Phalcon\Queue\Beanstalk::connect` | |||
- Fixed `Phalcon\Http\Response::redirect` bug[#11324](https://github.com/phalcon/cphalcon/issues/11324). Incorrect initialization local array of status codes | |||
|
|||
- Fixed `Phalcon\Http\Response::redirect` bug[#11324](https://github.com/phalcon/cphalcon/issues/11324). Incorrect initialization local array of status codes- Fixed cache backends bug[#11322](https://github.com/phalcon/cphalcon/issues/11322) related to saving number 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put your changes at new line
1037e14
to
9320aad
Compare
@sergeyklay added another test cases & changed wrong |
Fixed cache backends bug #11322
Thanks |
It's a PR to save number 0 in cache. (issue #11322)