Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: getEventsManager returning null #15010

Closed
niden opened this issue May 5, 2020 · 2 comments · Fixed by #15348
Closed

[BUG]: getEventsManager returning null #15010

niden opened this issue May 5, 2020 · 2 comments · Fixed by #15348
Assignees
@Izopi4a
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low

Comments

@niden
Copy link
Member

niden commented May 5, 2020

The getEventsManager() could return null in certain circumstances. The signature needs to change throughout the framework

public function getEventsManager() -> <EventsManagerInterface> | null
@niden niden added bug A bug report status: low Low labels May 5, 2020
@Jeckerson Jeckerson added the 5.0 The issues we want to solve in the 5.0 release label Mar 26, 2021
@Jeckerson Jeckerson added this to the 5.0.0 milestone Mar 26, 2021
@Izopi4a
Copy link
Member

Izopi4a commented Mar 27, 2021

changes are in #15348

@niden niden mentioned this issue Mar 28, 2021
Merged
5 tasks
@niden niden linked a pull request Mar 28, 2021 that will close this issue
update declarions of function getEventsManager() to allow null return #15348
Merged
5 tasks
@niden
Copy link
Member Author

niden commented Mar 28, 2021

Fixed in #15348

@niden niden closed this as completed Mar 28, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Izopi4a Izopi4a

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update declarions of function getEventsManager() to allow null return Izopi4a/cphalcon
3 participants
@niden @Jeckerson @Izopi4a