Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing Interface imports #14249

Merged
merged 11 commits into from
Jul 17, 2019
Merged

Fixed missing Interface imports #14249

merged 11 commits into from
Jul 17, 2019
+12 −4

Conversation

zsilbi
Copy link
Member

@zsilbi zsilbi commented Jul 17, 2019 •
edited
Loading

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I have updated the relevant CHANGELOG

Small description of change:
Some interfaces were not imported properly after refactoring.
Fixed missing imports in Phalcon\Db\Adapter\AbstractAdapter, Phalcon\Db\Adapter\AdapterInterface, Phalcon\Db\Result\Pdo, Phalcon\Html\Tag and Phalcon\Tag\Select.

Thanks,
zsilbi

@zsilbi zsilbi changed the title Db\DialectInterface was missing imports in AbstractAdapter Db\DialectInterface was missing from imports in AbstractAdapter and AdapterInterface Jul 17, 2019
@codecov
Copy link

codecov bot commented Jul 17, 2019 •
edited
Loading

Codecov Report

Merging #14249 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #14249   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files         489      489           
  Lines      112605   112605           
=======================================
  Hits        74200    74200           
  Misses      38405    38405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0530d1e...6c2957a. Read the comment docs.

@zsilbi zsilbi changed the title Db\DialectInterface was missing from imports in AbstractAdapter and AdapterInterface Missing imports in AbstractAdapter and AdapterInterface Jul 17, 2019
@zsilbi zsilbi changed the title Missing imports in AbstractAdapter and AdapterInterface [WIP] Missing imports in Phalcon\Db Jul 17, 2019
@zsilbi zsilbi changed the title [WIP] Missing imports in Phalcon\Db [WIP] Fixed missing Interface imports Jul 17, 2019
@zsilbi zsilbi changed the title [WIP] Fixed missing Interface imports Fixed missing Interface imports Jul 17, 2019
@sergeyklay sergeyklay merged commit 68fed33 into phalcon:4.0.x Jul 17, 2019
@sergeyklay
Copy link
Contributor

Thank you

@zsilbi zsilbi deleted the db-adapter-missing-dialectinterface branch July 17, 2019 13:30
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsilbi @sergeyklay @niden