Updated Model\Manager relations getter functions #14115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 22, 2019 14:50
Moved parameter to be the last, it's rarely every used Modified ManagerInterface accordingly
- Manager::getBelongsToRecords() - Manager::getHasOneRecords() - Manager::getHasManyRecords() and in ManagerInterface accordingly
multi field relations.
zsilbi
changed the title
niden
added
breaks bc
|
Thank you @zsilbi |
niden
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
In
Phalcon\Mvc\Model\Manager::getRelationRecords()function,$methodparameter is not alwaysstring. (most of the time it'snull)It's optional and rarely ever used so I think it should be the last parameter. (This Breaks BC)
Same applies to:
Phalcon\Mvc\Model\Manager::getBelongsToRecords()Phalcon\Mvc\Model\Manager::getHasOneRecords()Phalcon\Mvc\Model\Manager::getHasManyRecords()Modified the interfaces and usage everywhere accordingly.
Made some minor changes inside
Phalcon\Mvc\Model\Manager::getRelationRecords().Added tests for
Phalcon\Mvc\Model\Manager::getRelationRecords(), also for issue: #11504Thanks,
zsilbi