Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using Path::exists #1183

Closed
workingjubilee opened this issue Jul 1, 2023 · 0 comments · Fixed by #1186
Closed

Avoid using Path::exists #1183

workingjubilee opened this issue Jul 1, 2023 · 0 comments · Fixed by #1186
Labels
confusing This doesn't seem right diagnostics

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Jul 1, 2023

Its use should probably be considered more discouraged than it already is, as it is prone to reporting non-existence in cases of permission errors which can make already-confusing build errors even harder to debug. This will improve diagnostics during builds.

Found while glancing at timescale/timescaledb-toolkit#762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confusing This doesn't seem right diagnostics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant