From 25b73e67fff1f228feed7b1799d8f94799e767c1 Mon Sep 17 00:00:00 2001 From: Shimpei Makimoto Date: Sat, 11 Feb 2017 01:29:19 +0900 Subject: [PATCH 1/3] Use Integer class for checking integer instead of Fixnum Since Fixnum and Bignum are unfied into Integer in Ruby 2.4+, a warning occurs for using Fixnum (or Bignum). --- lib/pg_query/deparse.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pg_query/deparse.rb b/lib/pg_query/deparse.rb index eddd0ced..b2088ed5 100644 --- a/lib/pg_query/deparse.rb +++ b/lib/pg_query/deparse.rb @@ -22,7 +22,7 @@ def from(item) def deparse_item(item, context = nil) # rubocop:disable Metrics/CyclomaticComplexity return if item.nil? - return item if item.is_a?(Fixnum) + return item if item.is_a?(Integer) type = item.keys[0] node = item.values[0] From 29e4bd7877309c9578db77aa05c82cb192510e31 Mon Sep 17 00:00:00 2001 From: Shimpei Makimoto Date: Sat, 11 Feb 2017 01:41:35 +0900 Subject: [PATCH 2/3] Add Ruby 2.4.0 to build target --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 5b21b645..ffef0004 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,4 +5,5 @@ rvm: - 2.1.8 - 2.2.4 - 2.3.0 + - 2.4.0 script: bundle exec rake From ddfb982e2459c51957fb6f1243e474a2e4c1bc5e Mon Sep 17 00:00:00 2001 From: Shimpei Makimoto Date: Sat, 11 Feb 2017 01:53:25 +0900 Subject: [PATCH 3/3] Update json to 2.0.3 json 1.8.3 cannot be build with Ruby 2.4 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index f3e84578..4854b5f6 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -11,7 +11,7 @@ GEM astrolabe (1.3.0) parser (>= 2.2.0.pre.3, < 3.0) diff-lcs (1.2.5) - json (1.8.3) + json (2.0.3) parser (2.2.2.5) ast (>= 1.1, < 3.0) powerpack (0.1.1)