Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Bifurcated Resolve Handling #1404

Closed
jsirois opened this issue Aug 17, 2021 · 2 comments
Closed

Implement Bifurcated Resolve Handling #1404

jsirois opened this issue Aug 17, 2021 · 2 comments
Labels
bug resolver wontfix

Comments

@jsirois
Copy link
Member

jsirois commented Aug 17, 2021

Avoid the bug spelled out in python-poetry/poetry#4381.
@jsirois
Copy link
Member Author

jsirois commented Aug 17, 2021

Depends on #1402 which is where the bug will appear.

@jsirois jsirois mentioned this issue Aug 17, 2021
Closed
@jsirois jsirois mentioned this issue Mar 3, 2022
Closed
@jsirois
Copy link
Member Author

jsirois commented Mar 3, 2022

It's not clear that this needs to be addressed since its only an issue when attempting to export a lock to requirements.txt format for direct ingestion by Pip. Pex will be handling resolving from lock files natively and avoiding the Pip resolver altogether. Pip will only be called in to turn sdists, VCS projects and local projects into wheels and install wheels in chroots if needed. As such, I'm going to close this bug as obsoleted by not needing to export any longer, and #1645 tracks removing that subcommand.

@jsirois jsirois added the wontfix label Mar 3, 2022
@jsirois jsirois closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug resolver wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsirois