-
Notifications
You must be signed in to change notification settings - Fork 16
/
Copy pathNOTES.txt
29 lines (17 loc) · 826 Bytes
/
NOTES.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
Few questions:
do we want to support unit = 'deg' or "deg"
rotmx has this code, none of the other similar functions do
p = inputParser;
addRequired(p, 'theta', @(x) (isreal(x) & isscalar(x)) | isa(x, 'sym'));
addOptional(p, 'unit', "rad", isstring(x));
p.parse(theta, varargin{:});
which I hacked to
p = inputParser;
addRequired(p, 'theta', @(x) (isreal(x) & isscalar(x)) | isa(x, 'sym'));
addOptional(p, 'unit', "rad", @(x) isstring(x) | ischar(x) );
p.parse(theta, varargin{:});
it seems like a lot of overhead on a very simple function.
My old units tests do stuff like:
verifyError(tc, @()rotmx([1 2 3]),'SMTB:rotx:badarg');
but is this still the way to do things?
Design decision, skew -> vector, should it be row or column?