Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react hot reload? #11

Closed
dlebedynskyi opened this issue Sep 27, 2016 · 5 comments
Closed

Remove react hot reload? #11

dlebedynskyi opened this issue Sep 27, 2016 · 5 comments

Comments

@dlebedynskyi
Copy link

See gaearon/react-hot-boilerplate#97 (comment)

it looks like react hot reloader is dead. In a good way. Btw really great project 👍

@peter-mouland
Copy link
Owner

peter-mouland commented Sep 27, 2016

hmmm, interesting discussion, I can see the reason for his pivot! thanks for pointing out the link.

I'll have to let this sleep on it and also see how the community Reacts.

@dlebedynskyi
Copy link
Author

dlebedynskyi commented Sep 27, 2016

@peter-mouland yap.
just giving heads up. I did picked up a lot from this repo myself
It looks like a lot of work he plans to cover in create react app.

What is missing is server stuff since apparently not going to happen facebook/create-react-app#500 (comment)

Imho I'd really love to see create-react-app + universal part.

@peter-mouland
Copy link
Owner

yeah, I'm sure they'll get round to it, sounds like stability is key t start with which is fair.

There seems to be a few great boiler-plates/helpers out there that are missing that sometimes essential ingredient of being universal. when i have the time i'll take start of this app back one level and do a branch to show client-side react vs universal react.

@ngoctranfire
Copy link

I would like to say that one of the things that we forget is that most of the time, react-hot-loader is not a standalone that is used by itself. With stores/redux in mind, this makes hot-reloading a little bit trickier. I think having an example that branches off from the redux branch will make it more friendly, and maybe one that is branched off the react-router-4 as well? There are so many moving parts at any time.

@peter-mouland
Copy link
Owner

Thanks for the discussion guys. I'm going to leave it in at least until React comes with it baked in.

The other branches makes sense as suggestions so i've raised issues for those (PR's welcome!) Hopefully it'll be as easy as the webpack2-rhl branch which just worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants