Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container does not support git-lfs #43

Closed
qoutland opened this issue Sep 25, 2019 · 4 comments · Fixed by #45
Closed

Container does not support git-lfs #43

qoutland opened this issue Sep 25, 2019 · 4 comments · Fixed by #45

Comments

@qoutland
Copy link
Contributor

When trying to run this action with a repo that is using git-lfs it errors out with the following error: This repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting .git/hooks/post-checkout.

I tried installing git-lfs python package, which did not work since it must be called using python3 -m git_lfs vs the required git-lfs.

I will later be submitting a PR to fix this issue, by changing the base image to alpine and installing required packages. Up to you if you want to accept it, but it works for me here:
https://github.com/qoutland/create-pull-request

@peter-evans
Copy link
Owner

peter-evans commented Sep 26, 2019

I'm happy to accept the changes you proposed in your PR, but did you check out the new multi-platform version I created recently? This doesn't use a container and so git-lfs should be in the path already.
According to this documentation, Git Large File Storage is installed by default in virtual environments.
https://help.github.com/en/articles/software-in-virtual-environments-for-github-actions

    - name: Create Pull Request
      uses: peter-evans/create-pull-request@v1.3.1-multi
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@qoutland
Copy link
Contributor Author

I did not actually look into this, but I will check it out tomorrow sometime! Thanks!

@peter-evans
Copy link
Owner

Even if the multi-platform version works fine for you I'm still interested in merging your proposed change to the original container version of this Action. I'm not sure what direction GitHub are going to take to support other platforms and/or Action languages yet, so I'm maintaining both versions for the time being.
See this comment for a bit more background. #40 (comment)

@peter-evans
Copy link
Owner

peter-evans commented Sep 26, 2019

I merged your change and created a new release. Thanks!

    - name: Create Pull Request
      uses: peter-evans/create-pull-request@v1.3.1
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

If you have chance, I would appreciate feedback on the multi version. I would like to know if it works for repos using git-lfs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants