Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save on record cause double save and 2 webhooks sent #298

Closed
MaayanPeleg opened this issue Jun 19, 2024 · 3 comments
Closed

Save on record cause double save and 2 webhooks sent #298

MaayanPeleg opened this issue Jun 19, 2024 · 3 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@MaayanPeleg
Copy link

Versions
NetBox Version: 3.7.8
NetBox DNS Version: 0.22.9
Python Version: 3.10

Describe the bug
When a record is updated with data and tags, and I look at the webhooks sent, I receive a webhook first of the data change, then a webhook with the tag change.

To Reproduce
Steps to reproduce the behavior:

  1. Got to a record object
  2. Update the record with tags and data

Expected result
I believe that there should only be one update and only one webhooks sent.

Actual result
It seems that a double update occurs, one for data and one for tags.

@peteeckel peteeckel self-assigned this Jun 19, 2024
@peteeckel peteeckel added bug Something isn't working wontfix This will not be worked on labels Jun 19, 2024
@peteeckel
Copy link
Owner

peteeckel commented Jun 19, 2024

Hi @MaayanPeleg,

this is a duplicate of #89.

Unfortunately it is due to a NetBox issue that was fixed in version 4.0.5, so I don't have a chance of backporting the fix to the legacy branch for NetBox 3.

I'm sorry, but it just can't be done.

@MaayanPeleg
Copy link
Author

Thank you and apologies for not noticing that this was a duplicate issue.

@peteeckel
Copy link
Owner

Never mind - you're by no means the first, the issue is really ugly and hard to spot.

The only way of getting rid of it is to upgrade NetBox to 4.0.5+ (and NetBox DNS to 1.x.x for NetBox 4 support), which will solve it immediately.

@peteeckel peteeckel added duplicate This issue or pull request already exists and removed wontfix This will not be worked on labels Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants