Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNAME doesn't allow leading underscore in domain labels #285

Closed
peteeckel opened this issue Jun 3, 2024 · 0 comments · Fixed by #286
Closed

CNAME doesn't allow leading underscore in domain labels #285

peteeckel opened this issue Jun 3, 2024 · 0 comments · Fixed by #286
Assignees
Labels
bug Something isn't working

Comments

@peteeckel
Copy link
Owner

peteeckel commented Jun 3, 2024

Versions
NetBox Version: 4.0.3
NetBox DNS Version: 1.0.1
Python Version: 3.11.5

Describe the bug
When adding a CNAME, leading underscores in domain labels result in the value failing validation.

To Reproduce
Steps to reproduce the behavior:

  1. Try to a CNAME record with the value e.g. selector1-example-com._domainkey._SOMEDOMAIN.onmicrosoft.com. (yes, Microsoft again)

Expected result
The CNAME is created with that value.

Actual result
The CNAME is not created, NetBox DNS complains that it isn't a valid DNS name.

Value validation is meant to be extremely tolerant because e.g. in case of CNAMEs we have no way of knowing what the name server responsible for resolving the value will accept for values. So leading underscores in domain labels should be perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant