diff --git a/src/Plugins/Coverage.php b/src/Plugins/Coverage.php index 0980ba32..668ff09f 100644 --- a/src/Plugins/Coverage.php +++ b/src/Plugins/Coverage.php @@ -27,20 +27,6 @@ final class Coverage implements AddsOutput, HandlesArguments */ private const MIN_OPTION = 'min'; - /** - * @var string - */ - private const ERRORS_ONLY_OPTION = 'errors-only'; - - /** - * @var string[] - */ - private const ALLOWED_OPTIONS = [ - self::COVERAGE_OPTION, - self::MIN_OPTION, - self::ERRORS_ONLY_OPTION, - ]; - /** * Whether it should show the coverage or not. */ @@ -51,11 +37,6 @@ final class Coverage implements AddsOutput, HandlesArguments */ public float $coverageMin = 0.0; - /** - * Whether it should show only errors or not. - */ - public bool $errorsOnly = false; - /** * Creates a new Plugin instance. */ @@ -70,7 +51,7 @@ public function __construct(private readonly OutputInterface $output) public function handleArguments(array $originals): array { $arguments = [...[''], ...array_values(array_filter($originals, function (string $original): bool { - foreach (self::ALLOWED_OPTIONS as $option) { + foreach ([self::COVERAGE_OPTION, self::MIN_OPTION] as $option) { if ($original === sprintf('--%s', $option)) { return true; } @@ -92,7 +73,6 @@ public function handleArguments(array $originals): array $inputs = []; $inputs[] = new InputOption(self::COVERAGE_OPTION, null, InputOption::VALUE_NONE); $inputs[] = new InputOption(self::MIN_OPTION, null, InputOption::VALUE_REQUIRED); - $inputs[] = new InputOption(self::ERRORS_ONLY_OPTION, null, InputOption::VALUE_NONE); $input = new ArgvInput($arguments, new InputDefinition($inputs)); if ((bool) $input->getOption(self::COVERAGE_OPTION)) { @@ -126,10 +106,6 @@ public function handleArguments(array $originals): array $this->coverageMin = (float) $minOption; } - if ((bool) $input->getOption(self::ERRORS_ONLY_OPTION)) { - $this->errorsOnly = true; - } - return $originals; } @@ -146,7 +122,7 @@ public function addOutput(int $exitCode): int exit(1); } - $coverage = \Pest\Support\Coverage::report($this->output, $this->coverageMin, $this->errorsOnly); + $coverage = \Pest\Support\Coverage::report($this->output); $exitCode = (int) ($coverage < $this->coverageMin); diff --git a/src/Support/Coverage.php b/src/Support/Coverage.php index ff7902ac..e0794522 100644 --- a/src/Support/Coverage.php +++ b/src/Support/Coverage.php @@ -74,7 +74,7 @@ public static function usingXdebug(): bool * Reports the code coverage report to the * console and returns the result in float. */ - public static function report(OutputInterface $output, float $coverageMin, bool $showErrorsOnly): float + public static function report(OutputInterface $output): float { if (! file_exists($reportPath = self::getPath())) { if (self::usingXdebug()) { @@ -126,10 +126,6 @@ public static function report(OutputInterface $output, float $coverageMin, bool $truncateAt = max(1, terminal()->width() - 12); - if ($showErrorsOnly && (float) $percentage >= $coverageMin) { - continue; - } - renderUsing($output); render(<< diff --git a/tests/Features/Coverage.php b/tests/Features/Coverage.php index e23d4772..77912e63 100644 --- a/tests/Features/Coverage.php +++ b/tests/Features/Coverage.php @@ -34,18 +34,6 @@ expect($plugin->coverageMin)->toEqual(2.4); }); -it('adds coverage if --errors-only exist', function () { - $plugin = new CoveragePlugin(new ConsoleOutput()); - expect($plugin->errorsOnly)->toBeFalse() - ->and($plugin->coverage)->toBeFalse(); - - $plugin->handleArguments([]); - expect($plugin->errorsOnly)->toBeFalse(); - - $plugin->handleArguments(['--errors-only']); - expect($plugin->errorsOnly)->toBeTrue(); -}); - it('generates coverage based on file input', function () { expect(Coverage::getMissingCoverage(new class() {