Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimatch 10.0.1 not suportet Node 18 #382

Closed
simatec opened this issue Aug 3, 2024 · 3 comments
Closed

minimatch 10.0.1 not suportet Node 18 #382

simatec opened this issue Aug 3, 2024 · 3 comments

Comments

@simatec
Copy link

simatec commented Aug 3, 2024

Can you please downgrade the minimatch 10.0.1 version again.
With the update to 10.0.1 Webdav no longer supports Node 18, which is still not End of Life and should be supported.

Thx ;)

@perry-mitchell
Copy link
Owner

Hi! Regardless of minimatch's node support, which I probably missed as you said - the tests still pass: https://github.com/perry-mitchell/webdav-client/actions/runs/10215635123

Which shouldn't be the case if it didn't support node 18 (specifically this run.

@perry-mitchell
Copy link
Owner

Seems it's just an engine requirement, so not major. I'll downgrade all the same, for now.

@simatec
Copy link
Author

simatec commented Aug 6, 2024

Thanks for the adjustments and for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants