Need help with typescript typings

[skjnldsv]

Hey @perry-mitchell

I'm patching the request method of your webdav lib, and typescript is complaining.
Do you have any tips on how to comply to this? I think this is an issue or misunderstanding from my part on the PatchFn type :)

    /**
     * Allow to override the METHOD to support dav REPORT
	 *
	 * @see https://github.com/perry-mitchell/webdav-client/blob/8d9694613c978ce7404e26a401c39a41f125f87f/source/request.ts
	 */
	const patcher = getPatcher()
	patcher.patch('request', (options: RequestOptions) => {
		if (options.headers?.method) {
			options.method = options.headers.method
			delete options.headers.method
		}
		return request(options)
	})
	return client

[perry-mitchell]

Hey @skjnldsv! Hmm, that's weird, it seems to work for me:

Is your typescript version up to date?

[skjnldsv]

typescript 4 or 5, both are stating the same :)
I'm seeing this on my Code IDE 🤔

[perry-mitchell]

I wonder if your IDE is using some other version of typescript?

Can you build with such a change? That should show if the version installed as a dependency is correct or not..

EDIT: It shouldn't I don't think, as you're using vscode..

[skjnldsv]

(wrong click)

Weirdly, I can build, but I don't know what tool the (vs)code extension is using, i'll investigate.

[skjnldsv]

Let's close, can't find anything 🤷

[skjnldsv]

Actually, jest complains too 😁

    apps/files/src/services/WebdavClient.ts:45:27 - error TS2345: Argument of type '(options: RequestOptions) => Promise<Response>' is not assignable to parameter of type 'PatchFn<Promise<Response>>'.
      Types of parameters 'options' and 'args' are incompatible.
        Type 'unknown' is not assignable to type 'RequestOptions'.

    45  patcher.patch('request', (options: RequestOptions): Promise<Response> => {
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[susnux]

This will now work as the patch function is declared as

patch<T>(key: string, method: PatchFn<T>, opts?: PatchOptions): this;
//...
export type PatchFn<T> = (...args: Array<unknown>) => T;

So when passing (options: RequestOptions): Promise<Response> Typescript must convert the args of type unknown to RequestOptions but this is not allowed.
As you can not assign unknown to any other type without explicit casting.

The correct type would be

export type PatchFn<T> = (...args: Array<any>) => T;