diff --git a/.github/workflows/cli-tests.yml b/.github/workflows/cli-tests.yml index a3dfe7747..f8f80442f 100644 --- a/.github/workflows/cli-tests.yml +++ b/.github/workflows/cli-tests.yml @@ -13,7 +13,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ 1.23.x ] + go-version: [ 1.24.x ] name: CLI ${{inputs.make_target}} runs-on: ubuntu-latest timeout-minutes: 60 diff --git a/.github/workflows/dev-be-ci.yaml b/.github/workflows/dev-be-ci.yaml index d292d0dea..39c44cb67 100644 --- a/.github/workflows/dev-be-ci.yaml +++ b/.github/workflows/dev-be-ci.yaml @@ -26,7 +26,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ 1.23.x ] + go-version: [ 1.24.x ] may-fail: [ false ] continue-on-error: ${{ matrix.may-fail }} @@ -109,7 +109,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [1.23.x] + go-version: [1.24.x] may-fail: [false] continue-on-error: ${{ matrix.may-fail }} @@ -202,7 +202,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ 1.23.x ] + go-version: [ 1.24.x ] may-fail: [ false ] name: API Integration Tests @@ -382,7 +382,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ 1.23.x ] + go-version: [ 1.24.x ] may-fail: [ false ] runs-on: ubuntu-20.04 diff --git a/.github/workflows/dev-fe-e2e.yaml b/.github/workflows/dev-fe-e2e.yaml index 4d8d5f519..10b691ef9 100644 --- a/.github/workflows/dev-fe-e2e.yaml +++ b/.github/workflows/dev-fe-e2e.yaml @@ -17,7 +17,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ 1.23.x ] + go-version: [ 1.24.x ] may-fail: [ false ] runs-on: ubuntu-latest steps: diff --git a/.github/workflows/feature-build.yaml b/.github/workflows/feature-build.yaml index bfc8e62c3..a00164bbe 100644 --- a/.github/workflows/feature-build.yaml +++ b/.github/workflows/feature-build.yaml @@ -75,7 +75,7 @@ jobs: strategy: fail-fast: false matrix: - go-version: [ 1.23.x ] + go-version: [ 1.24.x ] may-fail: [ false ] continue-on-error: ${{ matrix.may-fail }} diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0c592909a..32eb54f10 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,7 @@ You can find the definition of the custom resources in the [Everest operator rep ### Run everest locally 0. Prerequisites: - - Golang 1.23.x + - Golang 1.24.x - Make 3.x - Docker 20.x - Git 2.x diff --git a/Dockerfile b/Dockerfile index ab5e6cb8a..1511ad518 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.23-alpine as build +FROM golang:1.24-alpine as build WORKDIR /everest diff --git a/commands/namespaces/list.go b/commands/namespaces/list.go index 2a847a8e5..903390676 100644 --- a/commands/namespaces/list.go +++ b/commands/namespaces/list.go @@ -105,7 +105,7 @@ func printNamespacesTable(nsList []namespaces.NamespaceInfo) error { case columnName: row = append(row, ns.Name) case columnManagedByEverest: - row = append(row, len(ns.InstalledOperators) != 0) + row = append(row, len(ns.InstalledOperators) > 0) case columnOperators: row = append(row, strings.Join(ns.InstalledOperators, ", ")) } diff --git a/dev/everest-operator.Dockerfile b/dev/everest-operator.Dockerfile index 07a7b485d..a7911667e 100644 --- a/dev/everest-operator.Dockerfile +++ b/dev/everest-operator.Dockerfile @@ -6,7 +6,7 @@ COPY ./bin/manager ./manager ENTRYPOINT ["./manager"] # Build the Delve debuger -FROM golang:1.23-alpine as delve +FROM golang:1.24-alpine as delve RUN go install github.com/go-delve/delve/cmd/dlv@v1.24.0 RUN chmod +x /go/bin/dlv diff --git a/dev/everest.Dockerfile b/dev/everest.Dockerfile index 054add8c0..992605fe7 100644 --- a/dev/everest.Dockerfile +++ b/dev/everest.Dockerfile @@ -8,7 +8,7 @@ EXPOSE 8080 ENTRYPOINT ["./everest-api"] # Build the Delve debuger -FROM golang:1.23-alpine as delve +FROM golang:1.24-alpine as delve RUN go install github.com/go-delve/delve/cmd/dlv@v1.24.0 RUN chmod +x /go/bin/dlv diff --git a/go.mod b/go.mod index 89dcc26ea..4aea3daca 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/percona/everest -go 1.23.4 +go 1.24 replace ( github.com/containerd/containerd v1.7.12 => github.com/containerd/containerd v1.7.13 diff --git a/packaging/everestctl_builder.sh b/packaging/everestctl_builder.sh index 77d3f22b5..5ad72535c 100644 --- a/packaging/everestctl_builder.sh +++ b/packaging/everestctl_builder.sh @@ -81,11 +81,11 @@ install_go() { ARCH=$(echo $(uname -m) | sed -e 's:i686:i386:g') rm -rf /usr/local/go if [ x"$ARCH" = "xx86_64" ]; then - wget https://go.dev/dl/go1.23.0.linux-amd64.tar.gz - tar -C /usr/local -xzf go1.23.0.linux-amd64.tar.gz + wget https://go.dev/dl/go1.24.0.linux-amd64.tar.gz + tar -C /usr/local -xzf go1.24.0.linux-amd64.tar.gz else - wget https://go.dev/dl/go1.23.0.linux-arm64.tar.gz - tar -C /usr/local -xzf go1.23.0.linux-arm64.tar.gz + wget https://go.dev/dl/go1.24.0.linux-arm64.tar.gz + tar -C /usr/local -xzf go1.24.0.linux-arm64.tar.gz fi update-alternatives --install /usr/bin/go go /usr/local/go/bin/go 1 update-alternatives --set go /usr/local/go/bin/go diff --git a/pkg/cli/install/install.go b/pkg/cli/install/install.go index 46e38e5fe..5aedf14a6 100644 --- a/pkg/cli/install/install.go +++ b/pkg/cli/install/install.go @@ -228,20 +228,20 @@ func (o *Installer) printPostInstallMessage(out io.Writer) { count := 1 if len(o.cfg.NamespaceAddConfig.NamespaceList) == 0 { - message += fmt.Sprintf("\n\n%s", output.Numeric(count, titleStyle.Render("PROVISION A NAMESPACE FOR YOUR DATABASE:"))) + message += fmt.Sprintf("\n\n%s", output.Numeric(count, "%s", titleStyle.Render("PROVISION A NAMESPACE FOR YOUR DATABASE:"))) count++ message += "Install a namespace for your databases using the following command:\n\n" message += fmt.Sprintf("\t%s", commandStyle.Render("everestctl namespaces add [NAMESPACE]")) } - message += fmt.Sprintf("\n\n%s", output.Numeric(count, titleStyle.Render("RETRIEVE THE INITIAL ADMIN PASSWORD:"))) + message += fmt.Sprintf("\n\n%s", output.Numeric(count, "%s", titleStyle.Render("RETRIEVE THE INITIAL ADMIN PASSWORD:"))) count++ message += "Run the following command to get the initial admin password:\n\n" message += fmt.Sprintf("\t%s\n\n", commandStyle.Render("everestctl accounts initial-admin-password")) message += output.Warn("NOTE: The initial password is stored in plain text. For security, change it immediately using the following command:\n") message += fmt.Sprintf("\t%s", commandStyle.Render("everestctl accounts set-password --username admin")) - message += fmt.Sprintf("\n\n%s", output.Numeric(count, titleStyle.Render("ACCESS THE EVEREST UI:"))) + message += fmt.Sprintf("\n\n%s", output.Numeric(count, "%s", titleStyle.Render("ACCESS THE EVEREST UI:"))) count++ message += "To access the web UI, set up port-forwarding and visit http://localhost:8080 in your browser:\n\n" message += fmt.Sprintf("\t%s\n", commandStyle.Render("kubectl port-forward -n everest-system svc/everest 8080:8080")) diff --git a/pkg/cli/namespaces/add.go b/pkg/cli/namespaces/add.go index f226120b5..fe0d3e0e9 100644 --- a/pkg/cli/namespaces/add.go +++ b/pkg/cli/namespaces/add.go @@ -328,7 +328,7 @@ func (n *NamespaceAdder) GetNamespaceInstallSteps(ctx context.Context, dbNSChart err := n.validateNamespaceUpdate(ctx, namespace) if errors.Is(err, ErrCannotRemoveOperators) { msg := "Removal of an installed operator is not supported. Proceeding without removal." - _, _ = fmt.Fprint(os.Stdout, output.Warn(msg)) //nolint:govet + _, _ = fmt.Fprint(os.Stdout, output.Warn("%s", msg)) n.l.Warn(msg) break } else if err != nil { diff --git a/tools/go.mod b/tools/go.mod index 9a80021bc..8b3796360 100644 --- a/tools/go.mod +++ b/tools/go.mod @@ -1,8 +1,6 @@ module github.com/percona/everest/tools -go 1.23.0 - -toolchain go1.23.4 +go 1.24 require ( github.com/daixiang0/gci v0.13.5