Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop making subprojects mutate instances #310

Open
vreuter opened this issue May 26, 2019 · 3 comments
Open

Stop making subprojects mutate instances #310

vreuter opened this issue May 26, 2019 · 3 comments

Comments

@vreuter
Copy link
Member

vreuter commented May 26, 2019

#309 and many others. The mutability when working with subprojects is poor design. activate/deactivate calls should make new instance.

@vreuter
Copy link
Member Author

vreuter commented May 29, 2019

This probably shouldn't be attempted for 0.22

@vreuter vreuter removed this from the 0.22 milestone May 29, 2019
@nsheff nsheff added this to the 0.23.0 milestone May 29, 2019
@vreuter
Copy link
Member Author

vreuter commented Jun 17, 2019

This was mainly motivated mainly by issues that have since been solved and/or turned out to not directly relate to subproject activation/deactivation implementation. I still don't love the way those actions are implemented (affecting the instance on which they're called and allowing an end user or client code to use the same reference), but the implied proposal would be a big API change. With no more instance mutation, callers would need to assign the result to a variable for the method call to have any meaning where it's made. @nsheff should this large significant a change wait for a 1.x release?

@nsheff
Copy link
Contributor

nsheff commented May 4, 2020

@vreuter, I wanted to ping on this. @stolarczyk with the new version, how did you handle the amendments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants