Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looper should use hook/plugin system to construct pipestat config files #413

Closed
donaldcampbelljr opened this issue Sep 1, 2023 · 3 comments

Comments

@donaldcampbelljr
Copy link
Contributor

          Will proceed with having Looper construct a new pipestat config file from a given pipestat config file AND the pipeline interfaces. Looper will use that config file to construct pipestat manager objects. Future work will investigate using a `pre-project` hook to construct this namespace and associated config file.

Originally posted by @donaldcampbelljr in #412 (comment)

@donaldcampbelljr
Copy link
Contributor Author

donaldcampbelljr commented Sep 1, 2023

Similar to the pre_submission hooks that are evaluated before writing the submission script, it would be nice to move the construction (and updating) of the pipestat namespace to use a hook, perhaps at the project level. This pipestat namespace would be assembled from a given pipestat config (provided within the looper config file) and any pipestat relevant information contained within a pipeline interface file. This namespace would be used to check if pipestat is properly configured as well as for creating the relevant pipestat manager objects.

Challenges:

  • currently we have a pre_submission hook that updates the namespaces immediately before writing our submissions script. These namespaces are updated within this function. The pipestat namespace is created at this point in the program. We would need to move the creation of the pipestat namespace to earlier in the program.

@donaldcampbelljr
Copy link
Contributor Author

Related to but an improvement on #411

@donaldcampbelljr
Copy link
Contributor Author

With the most recent refactoring work, I believe this is no longer a relevant approach. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant