Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requiresMainQueueSetup warning #9

Open
rangav opened this issue Mar 10, 2018 · 6 comments
Open

requiresMainQueueSetup warning #9

rangav opened this issue Mar 10, 2018 · 6 comments

Comments

@rangav
Copy link
Contributor

rangav commented Mar 10, 2018

Hi

Does it require main Queue or not? getting react native warning

+ (BOOL)requiresMainQueueSetup
{
    return YES;
}
@pentarex
Copy link
Owner

Hi @rangav !
When are you getting this warning?

@rangav
Copy link
Contributor Author

rangav commented Mar 11, 2018

When you build the RN proj in xcode, you will see warnings in output

OR when remote js dubug enabled we will see in chrome console

@pentarex
Copy link
Owner

facebook/react-native#17679
I guess it should return NO, The Image loader that this library is using is rewritten from RCTImageLoader (because I wanted to remove the dependencies). And somehow makes sense to be NO, because we don't want to block the app while loading the images. Anyhow its warning and its by default in the background.

I will fix it today and upload a new version, anyhow I have to add request authorisation to android :)

@rangav
Copy link
Contributor Author

rangav commented Mar 11, 2018

Thanks @pentarex will change to NO and will do some testing.

@pentarex
Copy link
Owner

ok please let me know :)

@rangav
Copy link
Contributor Author

rangav commented Mar 13, 2018

returning NO is working.

+ (BOOL)requiresMainQueueSetup
{
    return NO;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants