Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[headless.account.views.LoginView] Prevent login while logged in? #4008

Closed
mecampbellsoup opened this issue Aug 2, 2024 · 2 comments
Closed
Labels

Comments

@mecampbellsoup
Copy link
Contributor

Similarly to #3916, what is allauth's stance on permitting or prohibiting POST /login calls when the request is already authenticated?

We observe that currently there is nothing preventing it, and we are just curious if that is intentional.

@mecampbellsoup mecampbellsoup changed the title [headless.account.views.LoginView] [headless.account.views.LoginView] Prevent login while logged in? Aug 2, 2024
@pennersr
Copy link
Owner

pennersr commented Aug 3, 2024

It's not intentional. It's not a real issue either. Still, it would be good to return a 409 as well here for consistency. You could argue that this is a backwards incompatible change, but it's a corner case really, the frontend should not be showing an option to login anyway.

@pennersr pennersr added the TODO label Aug 3, 2024
@pennersr
Copy link
Owner

pennersr commented Aug 3, 2024

Fixed via f724e28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants