Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock tests for the comment processor module are missing #8

Closed
3 tasks done
penguineer opened this issue May 5, 2022 · 1 comment · Fixed by #23
Closed
3 tasks done

Mock tests for the comment processor module are missing #8

penguineer opened this issue May 5, 2022 · 1 comment · Fixed by #23
Assignees
Labels
debt Technical Debt
Milestone

Comments

@penguineer
Copy link
Owner

penguineer commented May 5, 2022

The Comment Processor module introduced in #4 has only TODOs for mock tests. Add mock tests here:

  • Put GitHub flow in distinct processor → already minimal
  • Decide about good location for recaptcha check (form or processor?)
  • TestCommentProcessor
@penguineer penguineer added the bug Something isn't working label May 5, 2022
@penguineer penguineer self-assigned this May 5, 2022
@penguineer penguineer added debt Technical Debt and removed bug Something isn't working labels May 6, 2022
@penguineer penguineer added this to the v1.0.0 milestone May 6, 2022
@penguineer
Copy link
Owner Author

Decided to leave the recaptcha check where it is right now.
However, in a later version it might be beneficial to move it to the Processor, as recaptcha check and gettting the HEAD can be run in parallel to save on time.

@penguineer penguineer linked a pull request May 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical Debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant