-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand umlauts #146
expand umlauts #146
Conversation
Fun fact of the day: In Germany, A Big Mac used to be a Big Mäc. And the Filet-o-Fish was the Fishmäc. The spelling with the umlaut actually gets German speakers a little closer to the English pronunciation of “Mac.” But in 2007 McDonald’s took away the umlauts, and now Germans have to get boring ol’ Big Macs like the rest of us. |
This PR would break some existing behavior, eg: records indexed as prior to this PR the term It seems like a better strategy would be to import two versions of the same token; once as |
Do we want to close this PR in favor of something icu related? |
I don't believe the ICU library will handle this type of expansion. |
This feature will require alt-names as the country name above can have 3 forms:
moving to alt-names feature as it can only be solved for a maximum of 2 cases before then. |
Closed due to teh new hotness |
[DO NOT MERGE] at this time
closes #74
closes pelias/pelias#319