Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layers): map PCLD feature code to dependency #402

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

missinglink
Copy link
Member

@missinglink missinglink commented Nov 10, 2021

Our current deduplication logic prefers https://www.geonames.org/4566967/puerto-rico.html over https://www.geonames.org/4566966/puerto-rico.html

This is likely due to both being classified as a 'venue'.

This PR maps the PCLD feature code to dependency (previously there was no mapping to dependency)

Screenshot 2021-11-10 at 15 12 23

grep PCLD allCountries.txt | cut -f1,2
3573511	Anguilla
661882	Ahvenanmaan Lääni
3573345	Bermuda
3371123	Bouvet Island
1547376	Territory of Cocos (Keeling) Islands
2078138	Territory of Christmas Island
3474414	Falkland Islands
2622320	Faroe Islands
3381670	Guyane
2411586	Gibraltar
3425505	Greenland
3579143	Guadeloupe
3474415	South Georgia and the South Sandwich Islands
4043988	Guam
1547314	Territory of Heard Island and McDonald Islands
1282588	British Indian Ocean Territory
3580718	Cayman Islands
4041468	Commonwealth of the Northern Mariana Islands
3570311	Martinique
3578097	Montserrat
2139685	New Caledonia
2155115	Territory of Norfolk Island
4030656	French Polynesia
3424932	Saint Pierre and Miquelon
4030699	Pitcairn, Henderson, Ducie and Oeno Islands
4566966	Puerto Rico
935317	Reunion
3370751	Saint Helena, Ascension, and Tristan da Cunha
3576916	Turks and Caicos Islands
4031074	Tokelau
5854968	United States Minor Outlying Islands
3577718	British Virgin Islands
4796775	United States Virgin Islands
4034749	Wallis et Futuna
1024031	Mayotte

@missinglink missinglink merged commit ce8bac5 into master Nov 10, 2021
@missinglink missinglink deleted the dependency_layer branch November 10, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant