Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG-822852] Add clarity to SRS Readme.md #637

Merged
merged 3 commits into from
Sep 28, 2023
Merged

[BUG-822852] Add clarity to SRS Readme.md #637

merged 3 commits into from
Sep 28, 2023

Conversation

kingakowalska1
Copy link
Contributor

Added clarity about when to use srs.enabled=true following documentation BUG-822852.

@kingakowalska1
[BUG-822852] Add clarity to SRS Readme.md
fa363bc 
Added clarity about when to use srs.enabled=true following documentation BUG-822852.
@kingakowalska1 kingakowalska1 requested a review from a team as a code owner September 25, 2023 12:51
@kotamsetti
Copy link

@kingakowalska1 Looks good 👍 ,
can you please update the same here https://github.com/pegasystems/pega-helm-charts/blob/kingakowalska1-patch-1/charts/backingservices/values.yaml#L12
https://github.com/pegasystems/pega-helm-charts/blob/kingakowalska1-patch-1/charts/backingservices/values.yaml#L41

thanks

@kingakowalska1 kingakowalska1 requested a review from a team as a code owner September 25, 2023 13:20
@kingakowalska1
Copy link
Contributor Author

@kingakowalska1 Looks good 👍 , can you please update the same here https://github.com/pegasystems/pega-helm-charts/blob/kingakowalska1-patch-1/charts/backingservices/values.yaml#L12 https://github.com/pegasystems/pega-helm-charts/blob/kingakowalska1-patch-1/charts/backingservices/values.yaml#L41

thanks

Hi, I added the changes to the values.yaml file as well.

taz-pega-work
taz-pega-work approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@taz-pega-work taz-pega-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes in README and values.yaml look great! nice work!

@kingakowalska1 kingakowalska1 merged commit 60980e2 into master Sep 28, 2023
11 checks passed
@kingakowalska1 kingakowalska1 deleted the kingakowalska1-patch-1 branch September 28, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandra-kalavakuri chandra-kalavakuri chandra-kalavakuri approved these changes

@taz-pega-work taz-pega-work taz-pega-work approved these changes

@Anand-Kotamsetti Anand-Kotamsetti Awaiting requested review from Anand-Kotamsetti

@bhowd1 bhowd1 Awaiting requested review from bhowd1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kingakowalska1 @kotamsetti @taz-pega-work @chandra-kalavakuri