cli_wallet core dumed on CTRL-D

[bobinson]

1. On master branch, compile cli_wallet
2. connect to a remote server
3. perform few operations
4. Press CTRL-D to exit & cli_wallet core dumps

bkb@pbsa01:~/pbsa/peerplays/programs/cli_wallet$ ./cli_wallet
Logging RPC to file: logs/rpc/rpc.log
257768ms th_a       main.cpp:120                  main                 ] key_to_wif( committee_private_key ): 5KCBDTcyDqzsqehcb52tW5nU6pXife6V2rX9Yf7c3saYSzbDZ5W
257769ms th_a       main.cpp:124                  main                 ] nathan_pub_key: PPY6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV
257769ms th_a       main.cpp:125                  main                 ] key_to_wif( nathan_private_key ): 5KQwrPbwdL6PhXujxW37FSSQZ1JiwsST4cqQzDeyXtP79zkvFD3
257770ms th_a       main.cpp:172                  main                 ] wdata.ws_server: wss://api.ppy.blckchnd.com
258280ms th_a       main.cpp:177                  main                 ] wdata.ws_user:  wdata.ws_password:
260362ms th_a       wallet.cpp:966                resync_active_tourna ] Checking my accounts for active tournaments
260621ms th_a       wallet.cpp:994                resync_active_tourna ] Account b0b1ns0n is not registered for any tournaments
260622ms th_a       thread.cpp:95                 thread               ] name:getline tid:140585854867200
locked >>> unlock 1
unlock 1
267901ms th_a       wallet.cpp:966                resync_active_tourna ] Checking my accounts for active tournaments
268161ms th_a       wallet.cpp:994                resync_active_tourna ] Account b0b1ns0n is not registered for any tournaments
null
unlocked >>>

unlocked >>>

unlocked >>>

272436ms th_a       wallet.cpp:1076               save_wallet_file     ] saving wallet to file wallet.json
pure virtual method called
terminate called without an active exception
Aborted (core dumped)

[xeroc]

Known issue that could be fixed by merging code from bitshares-core.

[bobinson]

@xeroc : Can you point to the relevant code change if you remember the same ?

[xeroc]

potentially related: bitshares/bitshares-core#1104

[abitmore]

Actually, it's bitshares/bitshares-core#1690, hasn't been fixed in BitShares yet.

[bobinson]

thanks @abitmore for the information

[bobinson]

• Tests should pass on Ubuntu 18.04, GCC-5.5, Boost Library 1.67.0
• The fix should be merged to https://github.com/peerplays-network/peerplays/tree/qa_gpos_18.04

[bobinson]

fixed via #89