-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coltrane doesn't display enharmonic intervals correctly #12
Comments
Alright. Can you better explain me how does that work? I think it's not hard to implement this. |
What's the general rule? Why doubly diminished fifth instead of perfect fourth? |
Intervals are a measure of two distances which are letter distance and distance in semitones. So any B up to any F must be some kind of 5th. A perfect fourth up from B would be an E and while the enharmonic equivelent note would be Fb, how the notes are spelled affect the intervals name since letter name is apart of the calculation. |
Alright. Thanks a lot for this information. |
Technically this is solved now. I had to completely refactor interval code for that. Would appreciate a lot if you could confirm :) |
Coltrane does not give the correct name when creating an interval that has a more common enharmonic equivalent. Due to this, Coltrane cannot be used for music theory centric applications.
This interval is C to D (or D _down to _ C) and should be a Major Second (Correct)
This interval is C to D# (or D# _down to _ C) and should be an Augmented Second (Wrong)
This interval is F to B (or B _down to _ F) and should be an Augmented Fourth (Correct)
This interval is B to F (or F _down to _ B) and should be a diminished fifth (Wrong, it gives and Augmented Fourth)
This interval is B to Fb (or Fb _down to _ B) and should be a doubly diminished fifth (Wrong, it gives a Perfect 4th)
The text was updated successfully, but these errors were encountered: