You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm evaluating this for a simple TOTP implementation, and in looking at the composer dependencies, this requires php7.3 and also your php-random-data class, which itself uses mcrypt and hence is incompatible with php7.2 and above, where mcrypt was removed. Is that simply an error in the composer dependency, and this might actually work with php7.1 or lower?
Thanks...
The text was updated successfully, but these errors were encountered:
Sorry, was reading in too much hurry on too small of a screen, I now see that php-random-class does check if the mcrypt function exists and is effectively a wrapper for random_bytes() for php7.0 and up.
As the minimum php version in composer.json is 7.3, it might make more sense to just use random_bytes directly?
Sorry for taking a long time to answer and thanks for your contribution.
I really didn't take a look on this lib since the initial release but this compatibility issue is crucial, tho I'd like to test myself before merging. Hope this won't take long.
Hello,
I'm evaluating this for a simple TOTP implementation, and in looking at the composer dependencies, this requires php7.3 and also your php-random-data class, which itself uses mcrypt and hence is incompatible with php7.2 and above, where mcrypt was removed. Is that simply an error in the composer dependency, and this might actually work with php7.1 or lower?
Thanks...
The text was updated successfully, but these errors were encountered: