-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnails are not used in final html, the resulted thumbnail is 14px height #32
Comments
What's the structure of the object your passing ? Is the issue that the thumbnail becomes too small ? |
Hello.
https://github.com/pedroabreu/ion-gallery/blob/master/dist/ion-gallery.js#L209 |
Is this still an issue ? |
I think it is. I've tried newest version, height is 0 (maybe I've made wrong structure of items, the structure is Testing in newest version |
You're getting 0 because you're passing the thumb property as null (And that's the image rendered as the item in the gallery). That's why you don't have src attribute on the image. As it is, either you don't define the property at all (just remove it from the object) or you need to define it's value. It's a bit silly as it is, I'll fix it in the next days |
Hi there,
Nice plugin. I tried to use but the final HTML discards the thumb image I passed to it
The final results looks like this
The text was updated successfully, but these errors were encountered: