Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite3 back-end incorrectly refers to 'resource' objects #38

Closed
MarkMaldaba opened this issue Apr 2, 2024 · 1 comment
Closed

sqlite3 back-end incorrectly refers to 'resource' objects #38

MarkMaldaba opened this issue Apr 2, 2024 · 1 comment
Labels

Comments

@MarkMaldaba
Copy link
Contributor

The sqlite3 back-end looks like it was created by copying and adapting the sqlite back-end. It therefore contains a lot of references to resource in function return types and comments.

However, the SQLite3 class class returns an SQLite3Result object for all query actions, not a resource instance. This has always been the case so is not a compatibility issue, just something that was missed when the DB_sqlite3 class was created.

As far as I can see, the only functional issue outside of the code comments and annotations is that there is an is_resource() check in the freeResult() function, which means that this function always returns false. In practice, there is nothing to free, so behaviour of the function is unaffected. However, any code which is checking the result of freeResult() may end up misreporting that an error occurred.

@schengawegga schengawegga added this to the Version 1.12.2 milestone Apr 2, 2024
@schengawegga
Copy link
Collaborator

Thank you @MarkMaldaba . I will have a look at it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants